Skip to content

feat(review): only request changes for security issues - #35

Merged
jmeridth merged 1 commit into
mainfrom
feat/review-comment-not-request-changes
Nov 4, 2026
Merged

jmeridth merged 1 commit into
mainfrom
feat/review-comment-not-request-changes

Conversation

@jmeridth

@jmeridth jmeridth commented Nov 4, 2026

Copy link
Copy Markdown
Owner

What/Why

The review skill now posts reviews with the COMMENT event unless a finding is a security issue. A change request makes me the blocker. A comment lets the author push updates and lets other maintainers approve and merge.

Proof it works

The bats suite passes (77 tests). The change is one rule in review/SKILL.md plus the plugin version bump to 0.1.23.

Risk

Low. Docs-only change to the skill; no scripts change.

AI role

Claude Opus 5.5 drafted the rule wording from my stated preference. I reviewed it and asked for the PR.

Review focus

Whether "security issue" is scoped clearly enough or needs examples.

## What/Why

Post reviews with the COMMENT event unless a finding is a security issue. A change request makes me the blocker, while a comment lets the author push updates and other maintainers approve and merge.

## Proof it works

pre-commit passes on all files (markdownlint, check json). bats tests/reassess passes (77 tests); the change is docs-only in review/SKILL.md plus the plugin version bump to 0.1.23.

## Risk

Low. One added rule in the review skill's drafting section; no scripts change.

## AI role

Rule wording drafted by Claude Opus 5.5 from my stated preference after a gemara-website review session; I asked for the change and approved pushing it.

## Review focus

Whether "security issue" is scoped clearly enough, or needs examples of what counts.

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Nov 4, 2026
@github-actions github-actions Bot added feature release Merging this PR triggers a release labels Nov 4, 2026
@jmeridth
jmeridth marked this pull request as ready for review November 4, 2026 03:45
@jmeridth
jmeridth merged commit d92063f into main Nov 4, 2026
4 checks passed
@jmeridth
jmeridth deleted the feat/review-comment-not-request-changes branch November 4, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature release Merging this PR triggers a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant